Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for pathlib.Path type #126

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

jpoppe
Copy link
Contributor

@jpoppe jpoppe commented Nov 4, 2023

I am looking for a replacement for ConfZ which uses native dataclasses instead of Pydantic. Ported my first (simple) configuration to dataconf and was missing Path (de)serialization/type support.

@jpoppe jpoppe changed the title feat: Support for pathlib.Path type feat: add support for pathlib.Path type Nov 4, 2023
@jpoppe
Copy link
Contributor Author

jpoppe commented Nov 4, 2023

After thinking a bit more about this and playing with dataconf I realized this pull request is not complete to match the current datconf flow, will maybe come back to this.

@jpoppe jpoppe closed this Nov 4, 2023
@zifeo
Copy link
Owner

zifeo commented Nov 4, 2023

@jpoppe can you elaborate what you feel is missing?

@jpoppe
Copy link
Contributor Author

jpoppe commented Nov 9, 2023

I reopened and think It should be fine to merge after a played a bit more, dataconf is not what I was exactly looking for, still nice work ;)

@jpoppe jpoppe reopened this Nov 9, 2023
@zifeo zifeo merged commit 74810c0 into zifeo:main Nov 9, 2023
10 checks passed
@zifeo
Copy link
Owner

zifeo commented Nov 9, 2023

@jpoppe indeed, not a serialization/deserialization lib. Thanks for the contrib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants